DOCSP-43148 - Refactor AWS authentication #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sanych-sun
suggested changes
Oct 17, 2024
| The following sections contain code examples that use the following placeholders: | ||
| To use AWS authentication, first perform the following steps: | ||
|
|
||
| - Add the ``MongoDB.Driver.Authentication.AWS`` NuGet package to your project. |
There was a problem hiding this comment.
Should we provide a link to nuget? https://www.nuget.org/packages/MongoDB.Driver.Authentication.AWS
|
|
||
| .. code-block:: csharp | ||
|
|
||
| MongoAuthentication.RegisterAwsAuthenticationProvider(); |
There was a problem hiding this comment.
Replace the code with the following one:
MongoClientSettings.Extensions.AddAWSAuthentication();
There was a problem hiding this comment.
That's really weird. I don't know where that line came from.
mongoKart
added a commit
that referenced
this pull request
Oct 18, 2024
Co-authored-by: Jordan Smith <[email protected]> (cherry picked from commit 1d75584)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloned from #250 after inadvertently closing v3.0 branch
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43148
Staging Links
Self-Review Checklist